Skip to content

Removes barrels#3736

Merged
waldekmastykarz merged 1 commit intopnp:mainfrom
waldekmastykarz:remove-barrels
Oct 2, 2022
Merged

Removes barrels#3736
waldekmastykarz merged 1 commit intopnp:mainfrom
waldekmastykarz:remove-barrels

Conversation

@waldekmastykarz
Copy link
Copy Markdown
Member

Removes barrels. While working on some new functionality for the CLI, I noticed circular references. It turns out, that when using barrels, when you reference something from the barrel, you load everything else that's in the barrel as well. That's undesirable and to avoid this in the future, I removed barrels and updated references to modules that we had in the barrels (Cli and utils).

@waldekmastykarz waldekmastykarz self-assigned this Oct 2, 2022
@waldekmastykarz waldekmastykarz merged commit f9506a3 into pnp:main Oct 2, 2022
@waldekmastykarz waldekmastykarz deleted the remove-barrels branch October 2, 2022 09:21
@waldekmastykarz waldekmastykarz added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 2, 2022
@waldekmastykarz waldekmastykarz added this to the v5.9 milestone Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accept for hacktoberfest, will merge later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant