Skip to content

Extending 'aad app add' command with admin consent process#3578

Closed
Adam-it wants to merge 1 commit intopnp:mainfrom
Adam-it:add-app-adminconsent-recreated
Closed

Extending 'aad app add' command with admin consent process#3578
Adam-it wants to merge 1 commit intopnp:mainfrom
Adam-it:add-app-adminconsent-recreated

Conversation

@Adam-it
Copy link
Copy Markdown
Member

@Adam-it Adam-it commented Aug 11, 2022

recreated PR #3455

@Adam-it
Copy link
Copy Markdown
Member Author

Adam-it commented Aug 11, 2022

@michaelmaillot after latest global refactoring of CLI commands I had a hard time in merging your PR and had some conflicts. In the end I could not do a rebase without merging which in the end git shows as change in many files... a lot more then actually were changed 😢.
In order to keep a clean git commit history I recreated your changes on this PR. 🙂
Please let me know if that's ok with you 👍 and if you could do a double check it would be also great 👍👍.
I also did a review on you initial PR and tested it locally and works perfectly (also after the merge 😜) so from my point of view it is ready to be merged

@michaelmaillot
Copy link
Copy Markdown
Contributor

Sounds good to me!

I've compared your files with mine, including updates brang by latest version and nothing wrong from my perspective.

@Adam-it
Copy link
Copy Markdown
Member Author

Adam-it commented Aug 15, 2022

Ok cool will merge it when possible. Thanks for the help 👍

@Adam-it
Copy link
Copy Markdown
Member Author

Adam-it commented Aug 15, 2022

merged manually

@Adam-it Adam-it closed this Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants