Adds support for upgrading SPFx projects to v1.15.2. Closes #3556#3562
Adds support for upgrading SPFx projects to v1.15.2. Closes #3556#3562garrytrinder merged 1 commit intopnp:mainfrom
Conversation
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
Very nice! Awesome work with the AST. Let's do a couple small adjustments and merge it 🚀
| new FN002023_DEVDEP_microsoft_eslint_config_spfx('1.15.2'), | ||
| new FN002001_DEVDEP_microsoft_sp_build_web('1.15.2'), | ||
| new FN002002_DEVDEP_microsoft_sp_module_interfaces('1.15.2'), | ||
| new FN002019_DEVDEP_spfx_fast_serve_helpers('1.15.2'), |
There was a problem hiding this comment.
We need to check this version. 1.15.2 has been released two months ago. Latest is 1.15.3 which has been released a month ago. Let's see which version targets SPFx v1.15.2 exactly.
There was a problem hiding this comment.
According to the docs, it's just a case of updating the helpers to match the desired SPFx version.
The migration is as easy as just changing the version of spfx-fast-serve-helpers in your package.json to match the corresponding SPFx minor version (do not change patch version).
For example, if your project is based on SPFx 1.11 and [email protected], then you have below dependency:
"spfx-fast-serve-helpers": "~1.11.0"
To migrate fast-serve to SPFx 1.12 you just need to change it like this (patch version should be 0, we change only minor version):
"spfx-fast-serve-helpers": "~1.12.0"
Reinstall all dependencies and that's it!
There was a problem hiding this comment.
If this is blocking the PR, let's remove it for now and add it later as an extra PR
There was a problem hiding this comment.
Since fast serve 1.15.3 was shipped before SPFx 1.15.2 I'd be wary of just accepting is as the right version without explicit verification. I'd rather have us use specific version to know for sure that the version we propose is correct and compatible with the specific version of SPFx.
There was a problem hiding this comment.
Should we open a new issue for this? Then the PR can continue without being blocked.
There was a problem hiding this comment.
I vote for removing this for now so we can progress and update later.
Should we open a new issue for this? Then the PR can continue without being blocked.
@Jwaegebaert that's a good idea, are you OK to raise the issue?
There was a problem hiding this comment.
But I'm pretty sure @s-KaiNet can give a beter explanation towards the implementation 😄
There is no correlation between patch versions, only major and minor version should match. I constantly publish fixes or updates to patch versions, thus the recommendation is always use the version with tilde ( i.e. ~1.15.0). When tilde is used, npm always installs the latest patch version. Hope this answers the question :)
garrytrinder
force-pushed
the
spfx-1-15-2
branch
from
9b67054 to
11e2aaa
Compare
garrytrinder
force-pushed
the
spfx-1-15-2
branch
2 times, most recently
from
2e48c50 to
c97bf7f
Compare
garrytrinder
force-pushed
the
spfx-1-15-2
branch
from
c97bf7f to
eb8f667
Compare
4 participants
No description provided.