v6: Updates classic references to spo site list. Closes #3522#3523
Merged
v6: Updates classic references to spo site list. Closes #3522#3523
Conversation
Contributor
Author
|
I'll keep this in draft till 5.5 is in production |
martinlingstuyl
changed the title
martinlingstuyl
force-pushed
the
MoveReferencesToSiteClassicList
branch
from
b5dfb36 to
1c3d1d6
Compare
martinlingstuyl
force-pushed
the
MoveReferencesToSiteClassicList
branch
from
1c3d1d6 to
4fecadb
Compare
Contributor
Author
|
I've targeted it at v6 now @plamber, seemed more sensible. So it can be reviewed and merged. |
martinlingstuyl
force-pushed
the
MoveReferencesToSiteClassicList
branch
from
4fecadb to
47e4f34
Compare
martinlingstuyl
force-pushed
the
MoveReferencesToSiteClassicList
branch
from
47e4f34 to
f471965
Compare
waldekmastykarz
force-pushed
the
v6
branch
2 times, most recently
from
e9e0f02 to
f76b591
Compare
Member
|
@martinlingstuyl thanks for you awesome work and sorry it's been taking so long. I will try to review and merge this PR in the coming days 😊 |
Adam-it
force-pushed
the
MoveReferencesToSiteClassicList
branch
from
f471965 to
cf9e6bb
Compare
Member
|
rebase ✅ |
Adam-it
approved these changes
Aug 28, 2022
Member
Adam-it
left a comment
Adam-it
left a comment
There was a problem hiding this comment.
looks good ✅
ready to merge 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3522
Updates classic references to spo site list.
Remarks
typeoption, based on work done in PR v6: Remove default type of spo site list. Closes #3526 #3528