Script samples contain an invalid condition check. Closes #3472#3511
Closed
Jwaegebaert wants to merge 2 commits intopnp:mainfrom
Closed
Script samples contain an invalid condition check. Closes #3472#3511Jwaegebaert wants to merge 2 commits intopnp:mainfrom
Jwaegebaert wants to merge 2 commits intopnp:mainfrom
Conversation
Member
|
Thanks! We'll review it shortly 👍 |
Member
|
I think we missed one sample here but all good. I will add it along the way while merging 👍 |
Adam-it
approved these changes
Jul 17, 2022
Member
Adam-it
left a comment
Adam-it
left a comment
There was a problem hiding this comment.
all good. Great work @Jwaegebaert 👍 You rock 🤩
Member
|
ready to merge |
Member
|
merged manually. Thanks for your awesome work 🤩 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3472