Updates spo tenant appcatalog add reference to deprecated spo site classic add command. Closes #3457#3459
Closed
martinlingstuyl wants to merge 1 commit intopnp:mainfrom
Closed
Conversation
Adam-it
approved these changes
Jul 8, 2022
Contributor
Author
|
Hi @Adam-it, no this PR can be merged already. |
Adam-it
requested changes
Jul 17, 2022
martinlingstuyl
force-pushed
the
updateDeprecatedReference
branch
from
f714b24 to
3e5b145
Compare
…assic add command. Closes pnp#3457
martinlingstuyl
force-pushed
the
updateDeprecatedReference
branch
from
3e5b145 to
0286032
Compare
Contributor
Author
|
I also fixed an issue that originated in the default output being json these days. Nobody must have executed the command in the meantime @Adam-it 😂 |
Member
hmm.. that could be one of the reasons I had a hard time testing this command locally 😅. Thanks for investigating this and the additional fixes 👍 you rock 🤩. |
Member
|
you rock 🤩merged manually 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3457
Updates
spo tenant appcatalog addreference to deprecatedspo site classic addcommand.Remark
We're currently still creating a classic AppCatalog site. This is OK, but SharePoint itself creates a modern AppCatalog site these days. This means SharePoint is much faster creating it. We might look into that using another issue. Maybe we can update the creation as well.