Consolidates spo site list and spo site classic list commands. Closes #1492#3456
Consolidates spo site list and spo site classic list commands. Closes #1492#3456martinlingstuyl wants to merge 1 commit intopnp:mainfrom
Conversation
|
I agree on removing the default for the list behavior |
Adam-it
left a comment
Adam-it
left a comment
There was a problem hiding this comment.
@martinlingstuyl good job 👍 you rock 🤩
I tested it and works really good 👍👍
I only have a one small improvement comment I noticed which might be just done along the merge.
Probably you would like to merge this yourself or wait for someone else to have a look at this as well so not merging it now but do let me know if you would like me to do it so you may focus on the important stuff 💪
| let siteType = options.type; | ||
|
|
||
| if (!siteType) { | ||
| siteType = 'TeamSite'; |
There was a problem hiding this comment.
I think if this is empty we could just return return 'GROUP#0' 🤔 not needed to fill this variable with some value in order to proceed in further logic if we may stop the complexity (as simple as is) already here?
|
BTW what a nice easter egg in the PR index 3->4->5->6 🤩 |
|
merged manually. Thanks for your awesome work 🤩 |
?? What line nrs? |
I mean the PR id is 3456 😋. What a perfect number. Almost like 1234 😉 |
2 participants
Closes #1492
This PR consolidates
spo site listandspo site classic listcommands.Remarks
spo site classic listcode and docs files in the source because of potential breaking changes. I've added a deprecation notice in the docs as well as in the command.spo site listwas originally built with a default type (by default it lists group connected team sites) I've kept this in to forego a breaking change, but I propose to remove the default in the next major version.--includeOneDriveSitestogether with an explicit--type All. This is to have clarity, regarding the default of the point above. After the next major version,type Allis default, and you would not need to specify it explicitly.webTemplateoption as an alternative totype. I've thought about combining them, but I think this is clearer for the end user.