Extends 'spo hubsite get' command. Closes #3421#3454
Conversation
|
Hi @Adam-it, @waldekmastykarz |
I only had a quick look over the phone but I think that if you are using another CLI command you should also mock it over the test. I will try to have a closer look over the weekend 👍 |
Adam-it
left a comment
Adam-it
left a comment
There was a problem hiding this comment.
@nanddeepn lets first work on fixing the test before we make a full review on this.
Please recheck the mentioned changes. After this is done and mocked the test should pass just fine
let me know if you will need any help with that 👍
|
@nanddeepn when you think the PR is ready to be reviewed please mark the done review comments as resolved and set 'ready for review' on the PR 👍 |
|
Hi @Adam-it |
|
Hi @waldekmastykarz |
|
I don't think we've reviewed it after your recent changes @nanddeepn, so let us please do that first, ok? |
Adam-it
left a comment
Adam-it
left a comment
There was a problem hiding this comment.
thanks @nanddeepn for you awesome work. We are really getting close 👍
please double check my comments and please mark them as resolved when done.
when your ready for another review please mark the PR as ready to review 👍
Once again thanks for your awesome work. You rock 🤩🤩
|
@nanddeepn could you also merge the main and resolve conflicts along the way ? |
|
Hi @Adam-it |
Adam-it
left a comment
Adam-it
left a comment
There was a problem hiding this comment.
resolved conflicts ✅
checked locally, works ✅
looks good ✅
test pass ✅
@nanddeepn I say this is ready to be merged. Great work 👍 you rock 🤩
|
merged manually |
3 participants
Extends
spo hubsite getcommand. Closes #3421Add the
includeAssociatedSitesoption to the command to return all associated sites for the individual hubsite.