Extends aad o365group recyclebinitem restore command with extra options. Closes #2031#3428
Closed
milanholemans wants to merge 4 commits intopnp:mainfrom
Closed
Extends aad o365group recyclebinitem restore command with extra options. Closes #2031#3428milanholemans wants to merge 4 commits intopnp:mainfrom
aad o365group recyclebinitem restore command with extra options. Closes #2031#3428milanholemans wants to merge 4 commits intopnp:mainfrom
Conversation
Member
|
thank for another awesome contribution 👍 |
waldekmastykarz
requested changes
Jul 7, 2022
Member
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
We're almost there. Let's change commandAction to use promises and we should be able to merge it
Adam-it
approved these changes
Jul 17, 2022
Member
Adam-it
left a comment
Adam-it
left a comment
There was a problem hiding this comment.
great job @milanholemans 👍 you rock 🤩.
Member
|
merged manually. Thanks for your awesome work 🤩 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
aad o365group recyclebinitem restorecommand with extra options. Closes #2031Comments
In the issue, the
--confirmflag is specified as option. I did not implement this because both commandsspo tenant recyclebinitem restoreandspo site recyclebinitem restoredon't implement this either. In addition, this would also be a breaking change.