Skip to content

Fixes spo field set command options inconsistency. Closes #3403#3418

Closed
milanholemans wants to merge 3 commits intopnp:mainfrom
milanholemans:spofieldset-options
Closed

Fixes spo field set command options inconsistency. Closes #3403#3418
milanholemans wants to merge 3 commits intopnp:mainfrom
milanholemans:spofieldset-options

Conversation

@milanholemans
Copy link
Copy Markdown
Contributor

Fixes spo field set command options inconsistency. Closes #3403

@Adam-it
Copy link
Copy Markdown
Member

Adam-it commented Jun 21, 2022

thanks for the awesome work. We'll review it shortly 👍

Copy link
Copy Markdown
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked 👍
looks great 😍. Amazing work, your rock 🤩
@pnp/cli-for-microsoft-365-maintainers anyone ready for a second round ?

Comment thread src/m365/spo/commands/field/field-set.ts Outdated
@Adam-it Adam-it self-assigned this Jun 24, 2022
@Adam-it Adam-it removed their assignment Jul 3, 2022
@milanholemans
Copy link
Copy Markdown
Contributor Author

Seems like a test timed out. Could someone retrigger the pipeline please?

@Adam-it Adam-it assigned Adam-it and unassigned Adam-it Jul 8, 2022
@Adam-it Adam-it removed their assignment Jul 9, 2022
@Adam-it
Copy link
Copy Markdown
Member

Adam-it commented Jul 9, 2022

merged manually.
thank you for your awesome work 👏

@Adam-it Adam-it closed this Jul 9, 2022
@milanholemans milanholemans deleted the spofieldset-options branch July 9, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spo field set options inconsistency

2 participants