Skip to content

Fixes documentation for spo file checkout#3388

Closed
MathijsVerbeeck wants to merge 1 commit intopnp:mainfrom
MathijsVerbeeck:spofilecheckoutdocumentationfix
Closed

Fixes documentation for spo file checkout#3388
MathijsVerbeeck wants to merge 1 commit intopnp:mainfrom
MathijsVerbeeck:spofilecheckoutdocumentationfix

Conversation

@MathijsVerbeeck
Copy link
Copy Markdown
Contributor

Fixes documentation of m365 spo file checkout command.
While I was writing a script sample, I had copied the example from the documentation. Upon executing this example (after obviously adding my parameters), I got error message: Error: Invalid option: 'url'

This option should be fileUrl.

@Adam-it
Copy link
Copy Markdown
Member

Adam-it commented Jun 9, 2022

@MathijsVerbeeck is this PR related to some issue 🤔?

@Adam-it Adam-it self-assigned this Jun 9, 2022
Copy link
Copy Markdown
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this fix 😊
good catch 👍👍

@Adam-it
Copy link
Copy Markdown
Member

Adam-it commented Jun 9, 2022

@MathijsVerbeeck you rock 🤩.
So writing sample script in CLI not only added a new example of how CLI may be used but also while creating it you found and already corrected an issue we have in the docs. Nice ! 😊
Seems like a awesome contribution 😍
@pnp/cli-for-microsoft-365-maintainers.request(secondOpinion) 🙏

@MathijsVerbeeck
Copy link
Copy Markdown
Contributor Author

MathijsVerbeeck commented Jun 9, 2022

@MathijsVerbeeck is this PR related to some issue 🤔?

@Adam-it As this was just a very minor fix, I thought that an issue would be overkill.

@waldekmastykarz waldekmastykarz self-assigned this Jun 9, 2022
Copy link
Copy Markdown
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Nothing to add 👍

@waldekmastykarz
Copy link
Copy Markdown
Member

Merged manually. Thank you! 👏

@waldekmastykarz waldekmastykarz added this to the v5.4 milestone Jun 9, 2022
@MathijsVerbeeck MathijsVerbeeck deleted the spofilecheckoutdocumentationfix branch October 12, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants