Skip to content

Spo web list#333

Closed
KbWorks wants to merge 4 commits intopnp:devfrom
KbWorks:spo-web-list
Closed

Spo web list#333
KbWorks wants to merge 4 commits intopnp:devfrom
KbWorks:spo-web-list

Conversation

@KbWorks
Copy link
Copy Markdown
Contributor

@KbWorks KbWorks commented Feb 25, 2018

Created the "spo web list" command incl test and documentation

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling def55a6 on KbWorks:spo-web-list into 3a263e4 on SharePoint:dev.

@waldekmastykarz
Copy link
Copy Markdown
Member

Woohoo! Thanks @KbWorks! Appreciate the help and I will have a look at it shortly!

@waldekmastykarz
Copy link
Copy Markdown
Member

Btw, have you tested if the current implementation would retrieve more than 500 subsites?

@KbWorks
Copy link
Copy Markdown
Contributor Author

KbWorks commented Feb 25, 2018

Nope have not tested with 500+ subsites.

@waldekmastykarz
Copy link
Copy Markdown
Member

Could you please do? It would be a shame if the command had this limitation.

@KbWorks
Copy link
Copy Markdown
Contributor Author

KbWorks commented Feb 26, 2018

Just tested it and works perfect

@waldekmastykarz
Copy link
Copy Markdown
Member

Nice! Thanks for checking!

@waldekmastykarz
Copy link
Copy Markdown
Member

Very nice first contribution. Merged manually with a few minor tweaks. Well done @KbWorks! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants