Adds 'tenant serviceannouncement healthissue get' command. Closes #2951#2973
Conversation
|
Awesome @SmitaNachan, we'll review it shortly 👏 |
|
Hi @SmitaNachan, We will merge the PR once #2948 is implemented. Cheers |
|
Hi @SmitaNachan, I just reviewed the command and I would like to ask you to do some more validations from your end. Could you please verify the output when using it in conjunction with the output text and CSV and remove the output that is not readable? Let me know if you have further questions. Cheers, |
|
Hi @plamber Adjusted the output for
|
|
Thank you @SmitaNachan , will come back to you asap |
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
I've done a couple of more adjustments to align the changes with existing commands
|
|
||
| ## Options | ||
|
|
||
| `-i, --issueId <issueId>` |
There was a problem hiding this comment.
Following the naming convention, we shouldn't repeat issue and just use id
|
|
||
| ## Examples | ||
|
|
||
| Get specified service health issue for tenant with issueId _MO226784_ |
There was a problem hiding this comment.
Let's simplify this to Gets information about issue with ID _MO226784_
| m365 tenant serviceannouncement healthissue get --issueId MO226784 | ||
| ``` | ||
|
|
||
| ## More information |
There was a problem hiding this comment.
We can skip this as referencing the underlying API has no added value to CLI's users
| issueId: string; | ||
| } | ||
|
|
||
| class TenantServiceAnnouncementHealthissueGetCommand extends GraphCommand { |
There was a problem hiding this comment.
For readability, let's spell the command's name as HealthIssue
| return 'Gets a specified service health issue for tenant'; | ||
| } | ||
|
|
||
| public defaultProperties(): string[] | undefined { |
There was a problem hiding this comment.
defaultProperties are meant to be used only on list commands where we return multiple items. Since we return a single item here, we shouldn't define them so that we return all properties.
|
|
||
| public getTelemetryProperties(args: CommandArgs): any { | ||
| const telemetryProps: any = super.getTelemetryProperties(args); | ||
| telemetryProps.issueId = typeof args.options.issueId !== 'undefined'; |
There was a problem hiding this comment.
Because issueId is required, there's no point in tracking its usage because it would always be true
3 participants
Adds
tenant serviceannouncement healthissue getcommand. Closes #2951