Skip to content

Added managementapp-add. Solves #2917#2918

Closed
appieschot wants to merge 1764 commits intopnp:gh-pagesfrom
appieschot:feature/cmd-2917
Closed

Added managementapp-add. Solves #2917#2918
appieschot wants to merge 1764 commits intopnp:gh-pagesfrom
appieschot:feature/cmd-2917

Conversation

@appieschot
Copy link
Copy Markdown
Member

@appieschot appieschot commented Jan 6, 2022

Added managementapp-add. Solves #2917

Vipul Kelkar and others added 30 commits June 11, 2021 11:42
@waldekmastykarz
Extends 'spo file list' with the recursive option. Closes pnp#2376
c27d8f2
@Abderahman88 @waldekmastykarz
Adds the Get-SPOUser CLI equivalents to the docs. Closes pnp#2485
e0435be
@Abderahman88 @waldekmastykarz
Removes the deprecated Get-TeamHelp cmdlet from the docs. Closes pnp#…
4a06290 
…2486
@waldekmastykarz
Updates release notes
266fd8d
@Abderahman88 @waldekmastykarz
Adds the Remove-PowerApp CLI equivalent to the docs. Closes pnp#2491
ec10e4c
@waldekmastykarz
Adds the 'spfx package generate' command. Closes pnp#2367
cdce8cb
@nanddeepn @waldekmastykarz
Adds the 'cli config reset' command. Closes pnp#2344
c6afe72
@waldekmastykarz
Updates release notes
b7c27c8
@waldekmastykarz
Excludes /assets/ path from loading commands. Closes pnp#2512
65d04b6
@garrytrinder @waldekmastykarz
Fixes 'o365group user list' command. Closes pnp#2374
f935e2b
@waldekmastykarz
Updates release notes
32f7c56
@waldekmastykarz
Adds site_url to docs
b223862
@SmitaNachan @waldekmastykarz
Adds the 'Remove pending SharePoint API permission requests' sample s…
e157772 
…cript. Closes pnp#2478
@nanddeepn @waldekmastykarz
Adds the 'Remove SharePoint API permissions' sample script. Closes pn…
ee4e000 
…p#2487
@Abderahman88 @waldekmastykarz
Extends 'pa app get' to allow retrieving apps by their display name. C…
aa7d064 
…loses pnp#2174
@waldekmastykarz
Updates release notes
7bddaa8
@appieschot @waldekmastykarz
Removes double JSON.stringify. Closes pnp#2534
b42d2a0
@appieschot @waldekmastykarz
Updates sample and removes double /. Closes pnp#2449
55a5e6d
@ktskumar @waldekmastykarz
Updates 'todo list add' to Graph v1.0. Closes pnp#2515
324aaf3
@ktskumar @waldekmastykarz
Updates 'todo list list' to Graph v1.0. Closes pnp#2516
d817227
@ktskumar @waldekmastykarz
Updates 'todo list remove' to Graph v1.0. Closes pnp#2517
ccc9ac2
@ktskumar @waldekmastykarz
Updates 'todo list set' to Graph v1.0. Closes pnp#2518
dec8b5e
@waldekmastykarz
Updates release notes
27ebc5e
@ktskumar @rabwill
Updates 'teams user app remove' to Graph v1.0. Closes pnp#2514
497c004
@ktskumar @rabwill
Updates 'teams user app add' to Graph v1.0. Closes pnp#2513
8f5a95d
@ktskumar @rabwill
Updates 'teams team set' to Graph v1.0. Closes pnp#2511
2aab24f
@appieschot @rabwill
Added documentation for JMESPath sort. Solves pnp#2536
a43e80e
@ktskumar @rabwill
Updates 'teams message reply list' to Graph v1.0. Closes pnp#2509
b666e9d
@rabwill
Updates release notes
fe0bd11
@appieschot @waldekmastykarz
Adds remarks to 'spo theme set' docs. Closes pnp#1633
243c968
waldekmastykarz
waldekmastykarz reviewed Jan 7, 2022
View reviewed changes
Comment thread src/m365/pp/commands/managementapp/managementapp-add.ts
@waldekmastykarz waldekmastykarz self-assigned this Jan 17, 2022
waldekmastykarz
waldekmastykarz requested changes Jan 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @appieschot, let's do a few changes before we merge it in

Comment thread docs/mkdocs.yml Outdated
Comment thread src/m365/pp/commands/managementapp/managementapp-add.ts Outdated
Comment thread src/m365/pp/commands/managementapp/managementapp-add.ts Outdated
Comment thread src/m365/pp/commands/managementapp/managementapp-add.ts Outdated
Comment thread src/m365/pp/commands/managementapp/managementapp-add.ts Outdated
@waldekmastykarz waldekmastykarz removed their assignment Jan 17, 2022
@waldekmastykarz waldekmastykarz marked this pull request as draft January 17, 2022 18:33
@appieschot appieschot marked this pull request as ready for review January 19, 2022 18:11
@appieschot
Copy link
Copy Markdown
Member Author

appieschot commented Jan 20, 2022

Okey implemented the the GraphTypes; just curious; as we use the getAppObjectId in app the m365 aad app commands; should we have an abstracted AppCommand class so we can have 1 implementation instead of the multitude we have now (used in app-get, app-role-add, app-role-delete, app-role-list and app-set commands (as well as this one but this might be a bit of an odd duck as this in the future should inherit from whatever we decide in #2961

@waldekmastykarz
Copy link
Copy Markdown
Member

waldekmastykarz commented Jan 22, 2022

Okey implemented the the GraphTypes; just curious; as we use the getAppObjectId in app the m365 aad app commands; should we have an abstracted AppCommand class so we can have 1 implementation instead of the multitude we have now (used in app-get, app-role-add, app-role-delete, app-role-list and app-set commands (as well as this one but this might be a bit of an odd duck as this in the future should inherit from whatever we decide in #2961

The more commands we add across M365, the clearer it becomes that methods like getAppObjectId are not specific to just one service. As such, we should revise our approach with implementing helper classes in base command classes and perhaps consider refactoring Utils to a set of logically grouped methods that can be used from anywhere in the CLI rather than just specific base classes. Let's discuss this in a separate issue.

@appieschot
Copy link
Copy Markdown
Member Author

appieschot commented Jan 22, 2022

I'll create an issue for it next week.

@appieschot appieschot mentioned this pull request Jan 25, 2022
Closed
@waldekmastykarz waldekmastykarz mentioned this pull request Jan 28, 2022
Closed
3 tasks
waldekmastykarz
waldekmastykarz reviewed Feb 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see a number of changes in mkdocs.yml that don't seem related to the PR? Before we continue with the review, could you please double check that no unintended changes have been included in the PR?

@waldekmastykarz waldekmastykarz marked this pull request as draft February 1, 2022 18:19
@appieschot
Copy link
Copy Markdown
Member Author

appieschot commented Feb 1, 2022

Will have a look later; I reverted the changes after rebasing but it still shows as changes (while manual compare shows that the marked changes are currently present in the main branch)..

@appieschot appieschot changed the base branch from main to gh-pages February 3, 2022 09:22
@appieschot appieschot closed this Feb 3, 2022
@appieschot
Copy link
Copy Markdown
Member Author

appieschot commented Feb 3, 2022

@waldekmastykarz sorry made a click error in the UI and it closed out my PR 🤭 created a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waldekmastykarz waldekmastykarz waldekmastykarz requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.