Skip to content

Removes the 'value' wrapper in the output. Closes #2292#2543

Closed
waldekmastykarz wants to merge 2 commits intopnp:v4from
waldekmastykarz:v4-no-value
Closed

Removes the 'value' wrapper in the output. Closes #2292#2543
waldekmastykarz wants to merge 2 commits intopnp:v4from
waldekmastykarz:v4-no-value

Conversation

@waldekmastykarz
Copy link
Copy Markdown
Member

Removes the 'value' wrapper in the output. Closes #2292

@appieschot
Copy link
Copy Markdown
Member

Would it make sense to update the docs and remove the JMESPath samples that focus on value filters in this PR as well? Those samples are no longer usable if we have the correct output so might clean up things a bit.

@waldekmastykarz
Copy link
Copy Markdown
Member Author

Good point! What if removing the samples altogether, we'd rephrase them? I think the concepts would be still valuable for list commands that return array albeit with a different angle. Shall we create a separate item to track this update? Would you like to pick it up? 😊

@appieschot
Copy link
Copy Markdown
Member

@waldekmastykarz you are absolutely right, we could rephrase it, feel free to create an issue and assign it to me 🚀

@waldekmastykarz
Copy link
Copy Markdown
Member Author

Merged manually

@waldekmastykarz waldekmastykarz deleted the v4-no-value branch June 26, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants