Skip to content

added teams bulk member add script #closes 2288#2311

Closed
plamber wants to merge 3 commits intopnp:mainfrom
plamber:provisiongroupwithmembers
Closed

added teams bulk member add script #closes 2288#2311
plamber wants to merge 3 commits intopnp:mainfrom
plamber:provisiongroupwithmembers

Conversation

@plamber
Copy link
Copy Markdown
Contributor

@plamber plamber commented Mar 27, 2021

This example starts from a Microsoft 365 Group.
As long we do not have #2021 solved I am not going to provide a sample with the teams endpoint

Copy link
Copy Markdown
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @plamber, would you mind double checking if the script works as intended? While running it, I see the first three attempts fail, the script showing command's help each time, and then proceeding with attempt 4 despite the max being set to 3:

image

If the script requires specific configuration or settings, let's include it in the script's page to help folks avoid running into issues.

Comment thread docs/docs/sample-scripts/teams/create-team-and-add-members-and-owners.md Outdated
@waldekmastykarz waldekmastykarz marked this pull request as draft April 2, 2021 17:57
@waldekmastykarz waldekmastykarz removed their assignment Apr 2, 2021
@plamber
Copy link
Copy Markdown
Contributor Author

plamber commented Apr 10, 2021

Hi @waldekmastykarz,
I performed the modifications as requested and added some more tweaks

br,

@waldekmastykarz waldekmastykarz marked this pull request as ready for review April 10, 2021 12:08
@waldekmastykarz waldekmastykarz self-assigned this Apr 10, 2021
Copy link
Copy Markdown
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I noticed that the script fails when you specify only owners or only members. It also seems to continue when creating the group failed. We can fix both these things in the next iteration 👍

Comment thread docs/mkdocs.yml
- 'Sync SharePoint document library documents with Azure storage container': 'sample-scripts/spo/sync-splib-into-az-storage-container.md'
- Microsoft Teams:
- 'Create a Microsoft Team with channels from a Microsoft 365 Group': 'sample-scripts/teams/create-team-from-group.md'
- 'Create a Microsoft Teams team and bulk add members from CSV file': 'create-team-and-add-members-and-owners.md'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect path to the script. Missing sample-scripts/teams/ in front on the file path

@waldekmastykarz
Copy link
Copy Markdown
Member

Merged manually. Thank you! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants