#2193 - Add CanvasContentJson to the output#2194
Closed
Conversation
waldekmastykarz
approved these changes
Feb 24, 2021
| .then((res: { CanvasContent1: string } | void) => { | ||
| if (res && res.CanvasContent1) { | ||
| const canvasData: any[] = JSON.parse(res.CanvasContent1); | ||
| pageItemData.CanvasContentJson = res.CanvasContent1; |
Member
There was a problem hiding this comment.
Since we're no longer using the HTML parsing, we can remove CanvasContent1 from the call on line 43.
Member
|
Merged manually. Thank you! 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
CanvasContent1JSON data to the output of thespo page getcommand. As we now do the second call to retrieve this data. It is beneficial to also return this data as part of the output (HTML content is already returned). Related to #2193