Extends aad app add with returning Directory ID. Closes #2187#2190
Closed
SmitaNachan wants to merge 2 commits intopnp:mainfrom
SmitaNachan:extend-aad-app-add
Closed
Extends aad app add with returning Directory ID. Closes #2187#2190SmitaNachan wants to merge 2 commits intopnp:mainfrom SmitaNachan:extend-aad-app-add
aad app add with returning Directory ID. Closes #2187#2190SmitaNachan wants to merge 2 commits intopnp:mainfrom
SmitaNachan:extend-aad-app-add
Conversation
Member
|
Hey @SmitaNachan, it looks like we have tests failing. Would you mind having another look? |
waldekmastykarz
approved these changes
Feb 24, 2021
|
|
||
| interface AppInfo { | ||
| appId: string; | ||
| // objectId |
Member
There was a problem hiding this comment.
We should keep this comment in to disambiguate id
| appId: _appInfo.appId, | ||
| objectId: _appInfo.id | ||
| objectId: _appInfo.id, | ||
| tenantId: Utils.getTenantIdFromAccessToken(auth.service.accessTokens[auth.defaultResource].value) |
Member
There was a problem hiding this comment.
For now this approach is good. If in the future we allow users to work on multiple directories, we'll need to adjust this.
Member
|
Merged manually. Thank you! 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
aad app addwith returning Directory ID. Closes #2187