Skip to content

Added M365 Prefix to Version command#2183

Closed
hugoabernier wants to merge 1 commit intopnp:mainfrom
hugoabernier:patch-2
Closed

Added M365 Prefix to Version command#2183
hugoabernier wants to merge 1 commit intopnp:mainfrom
hugoabernier:patch-2

Conversation

@hugoabernier
Copy link
Copy Markdown
Contributor

Added m365 prefix to version command for consistency with all other document samples.

@waldekmastykarz
Copy link
Copy Markdown
Member

Good catch! Thanks! 👏

@waldekmastykarz
Copy link
Copy Markdown
Member

Merged manually. Thank you! ❤️

@waldekmastykarz waldekmastykarz added this to the v3.6 milestone Feb 19, 2021
@hugoabernier
Copy link
Copy Markdown
Contributor Author

Oh no, I'm sorry you had to merge it manually! Please let me know what I did wrong so I'll spare you the trouble in the future?

@waldekmastykarz
Copy link
Copy Markdown
Member

That's totally not your fault. It's basically how we handle PRs.

When processing PRs, we choose to rebase them to have a clean log history. If necessary, we also update commit messages to be consistent so that it's easy for everyone else to follow what's been done where. The consequence of this approach is, that after first PR merged, all subsequent PRs are based on main branch that has different history so we need to merge them manually. Again, this is just how we chose to deal with PRs, and it's nothing you can control.

That said, I appreciate your concern and reaching out to help. Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants