Fixes failed spfx project rename test on Windows. Closes #1892#2072
Merged
waldekmastykarz merged 1 commit intopnp:masterfrom Jan 16, 2021
Merged
Fixes failed spfx project rename test on Windows. Closes #1892#2072waldekmastykarz merged 1 commit intopnp:masterfrom
waldekmastykarz merged 1 commit intopnp:masterfrom
Conversation
Member
|
Thanks! We'll review it shortly 👍 |
Contributor
|
@waldekmastykarz @garrytrinder can confirm this works on Windows 😎 Nice work @Abderahman88 👏🏽 |
Contributor
Author
|
Thank you @rabwill 😄 |
waldekmastykarz
approved these changes
Jan 16, 2021
Member
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
Awesome! Nothing to add. 👏
Member
|
Fantastic work on this @Abderahman88 👏 We really appreciate your efforts on this one ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1892