Fixes failed test on Windows. Closes #1892#1972
Closed
Abderahman88 wants to merge 1 commit intopnp:masterfrom
Closed
Fixes failed test on Windows. Closes #1892#1972Abderahman88 wants to merge 1 commit intopnp:masterfrom
Abderahman88 wants to merge 1 commit intopnp:masterfrom
Conversation
Member
|
Thanks for the suggested fix. I'm not sure if it's the right way about it. Since this file is not shipped with the built package, I wonder if it could suppress issues that would become evident only on runtime when using CLI on Windows. |
Member
|
As per @waldekmastykarz comment, lets mark this as draft whilst we agree on a way forward. |
Contributor
Author
|
@garrytrinder Agree. This PR still needs work 👷 |
waldekmastykarz
force-pushed
the
master
branch
from
3e0346e to
fea0c9a
Compare
Member
|
Not sure if I'm testing this correctly, but I've added the file to a branch which I pushed to remote, deleted the local repo, cloned again, switched to the branch with .gitattributes, ran |
Member
|
Closing this PR as we resolved the issue in #2072 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1892