Skip to content

[DOCS] Update login command docs to include links to user-guide articles#1966

Closed
YannickRe wants to merge 1 commit intopnp:masterfrom
YannickRe:improve-login-documentation
Closed

[DOCS] Update login command docs to include links to user-guide articles#1966
YannickRe wants to merge 1 commit intopnp:masterfrom
YannickRe:improve-login-documentation

Conversation

@YannickRe
Copy link
Copy Markdown
Contributor

Added links to the more generic documentation, and especially the caveats article directly from the login command documentation.
It helps users more easily discover the global user guide articles when struggling with a specific action in the login command.

Comment thread docs/docs/cmd/login.md Outdated

Managed identity in Azure Cloud Shell is the identity of the user. It is neither system- nor user-assigned and it can't be configured. To log in to Microsoft 365 using managed identity in Azure Cloud Shell, set `authType` to `identity` and don't specify the `userName` option.

See the following pages for more detailed information:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, more information generally points to external links. These are links to three internal articles that describe some more detail the steps to take when doing the authentication. I went for the login command to find my information, if it wasn't for someone on twitter providing me with the link to the Caveats article, I wouldn't have found it.
I feel they fit in that section, but maybe as part of the text, not as a summary. Like some sort of intro that points to the first article, mentioning the caveats article somewhere in the flow of the text. It would take some more effort into rewriting this part and still keep the flow.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to give it a try and rewrite the body to include the links in content?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll put it on the list 😃. If anyone else wants to take a jab at it before I get around to it, I will not feel offended 😉

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waldekmastykarz I made some effort to put the links in the flow of the text.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! We'll go through your suggestions asap. Thank you 👏

…eats article, directly from the login command documentation and in the flow of the text
@waldekmastykarz waldekmastykarz self-assigned this Dec 2, 2020
Copy link
Copy Markdown
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Nothing to add. Thank you! 👏

@waldekmastykarz
Copy link
Copy Markdown
Member

Merged manually. Thank you! 👏

@waldekmastykarz waldekmastykarz added this to the v3.4 milestone Dec 2, 2020
@YannickRe YannickRe deleted the improve-login-documentation branch December 5, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants