Extends teams channel get command with support for teamName and channelName options#1918
Merged
plamber merged 2 commits intopnp:masterfrom Nov 5, 2020
nanddeepn:extend-teams-channel-get
Merged
Extends teams channel get command with support for teamName and channelName options#1918plamber merged 2 commits intopnp:masterfrom nanddeepn:extend-teams-channel-get
teams channel get command with support for teamName and channelName options#1918plamber merged 2 commits intopnp:masterfrom
nanddeepn:extend-teams-channel-get
Conversation
Contributor
|
Thank you. We will have a look into this asap |
plamber
suggested changes
Nov 1, 2020
Contributor
plamber
left a comment
plamber
left a comment
There was a problem hiding this comment.
Thank you for your submission. Would you please have a look on my comment?
| } | ||
|
|
||
| const teamRequestOptions: any = { | ||
| url: `${this.resource}/v1.0/me/joinedTeams?$filter=displayName eq '${encodeURIComponent(args.options.teamName as string)}'`, |
Contributor
There was a problem hiding this comment.
By running this endpoint you assume that the person running the query filters the Teams just by the ones he/she is member of. Administrators might want to perform the query over several Teams
To have a more general approach I would suggest that you are going to use the /v1.0/groups endpoint and then filter by resourceProvisioningOptions -> Teams
Contributor
Author
|
Hi @plamber |
plamber
approved these changes
Nov 5, 2020
Contributor
|
Thank you for the work. Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended
teams channel getcommand with support to get information usingteamNameandchannelNameas options.Closes #1887