Skip to content

Fixes for CodeTour schema changes#1708

Closed
hugoabernier wants to merge 2 commits intopnp:masterfrom
hugoabernier:hb-feature-1602
Closed

Fixes for CodeTour schema changes#1708
hugoabernier wants to merge 2 commits intopnp:masterfrom
hugoabernier:hb-feature-1602

Conversation

@hugoabernier
Copy link
Copy Markdown
Contributor

Linked Issue

Relates to #1602

The CodeTour schema has changed since the CodeTour feature was released. This PR fixes .tour upgrade reports to work with CodeTour.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 13, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling d0a2110 on hugoabernier:hb-feature-1602 into 6619b8a on pnp:master.

@garrytrinder
Copy link
Copy Markdown
Member

Thanks! We'll review it shortly 👍

Comment thread src/o365/spfx/commands/project/project-upgrade.ts
@garrytrinder garrytrinder self-assigned this Jul 18, 2020
Copy link
Copy Markdown
Member

@garrytrinder garrytrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hugoabernier 👏🏻

Just the minor change to remove the codetour case as previously discussed.

Comment thread src/o365/spfx/commands/project/project-upgrade.ts
@garrytrinder
Copy link
Copy Markdown
Member

Merged manually. Thank you 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants