update the login name example - Login Name option value should be in double quote #1707
Closed
PrasadKasireddy wants to merge 2 commits intopnp:masterfrom
PrasadKasireddy:master
Closed
update the login name example - Login Name option value should be in double quote #1707PrasadKasireddy wants to merge 2 commits intopnp:masterfrom PrasadKasireddy:master
PrasadKasireddy wants to merge 2 commits intopnp:masterfrom
PrasadKasireddy:master
Conversation
Contributor
PrasadKasireddy
commented
Jul 10, 2020
PrasadKasireddy
commented
Member
|
Good catch! Thank you! We'll merge it shortly 👍 |
Correct the typo
Contributor
Author
|
@waldekmastykarz - could you please review the PR and commit as I am planning to pick another PR |
Member
|
Hey @PrasadKasireddy, we process PRs in the order they come in. To avoid being blocked by an open PR, you can use separate branch for each PR and submit a PR from there. That way, you always have a clean master branch that is in sync with our master. |
Member
|
Merged manually. Thank you 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.