Skip to content

Adding adding-app-catalog sample#1413

Closed
DRamalho92 wants to merge 2 commits intopnp:devfrom
DRamalho92:samples
Closed

Adding adding-app-catalog sample#1413
DRamalho92 wants to merge 2 commits intopnp:devfrom
DRamalho92:samples

Conversation

@DRamalho92
Copy link
Copy Markdown

Hi,

I've added a little description of the articles that published and the link to them.
Let me know if any adjustment is needed.
Thanks 😃

Adding hide list from site contents
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 19, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling cdfa93d on DRamalho92:samples into 621faa3 on pnp:dev.

Copy link
Copy Markdown
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! If you could have a look at the few comments I left, we'd get it in. Thank you! 👏

Comment thread docs/manual/docs/examples/spo/adding-app-catalog.md Outdated
Comment thread docs/manual/docs/examples/spo/adding-app-catalog.md Outdated
Comment thread docs/manual/docs/examples/spo/adding-app-catalog.md
@DRamalho92
Copy link
Copy Markdown
Author

Let me know if you need any change 😎😎

@waldekmastykarz
Copy link
Copy Markdown
Member

Appreciate the quick turnaround 👏

Copy link
Copy Markdown
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done! I've fixed two minor things when merging the PR. Appreciate the contribution! 👏

```bash tab="Bash"
#!/bin/bash

site=https://tricks365.sharepoint.com/sites/Com22
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to use the same URLs in both examples

# requires jq: https://stedolan.github.io/jq/

site=https://tricks365.sharepoint.com/sites/Com22
listName="Apps for SharePoint"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the same variables in both examples

@waldekmastykarz
Copy link
Copy Markdown
Member

Merged manually. Thank you once again and welcome to the crew! 👏

@waldekmastykarz waldekmastykarz added this to the v2.8 milestone Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants