Conversation
allow 'tacv2' channel id format.
Contributor
Author
|
Any chance that a super-small bugfix like this could be merged quickly? I'd rather not have to manually install my fork accross multiple servers... TIA! |
Contributor
|
@balbany, we can try to merge it with the next beta, that means next Sunday. Does that suit your timings? |
Contributor
Author
|
Sunday the 15th? That should be fine, thanks |
Contributor
|
Thanks! Adding @waldekmastykarz , @garrytrinder so they know this must go on the fast track. |
VelinGeorgiev
approved these changes
Mar 13, 2020
Contributor
VelinGeorgiev
left a comment
VelinGeorgiev
left a comment
There was a problem hiding this comment.
Looks good @balbany ! Thank you very much!
Member
|
Merged manually. Thank you @balbany 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1401
isValidTeamsChannelId - Fixing regex to allow 'tacv2' channel id format.