Resolving issue #740#1123
Closed
joakimhogberg wants to merge 1 commit intopnp:devfrom
joakimhogberg:feature/issue-740
Closed
Resolving issue #740#1123joakimhogberg wants to merge 1 commit intopnp:devfrom joakimhogberg:feature/issue-740
joakimhogberg wants to merge 1 commit intopnp:devfrom
joakimhogberg:feature/issue-740
Conversation
Member
|
Thanks! We'll review it shortly! |
waldekmastykarz
approved these changes
Sep 28, 2019
Member
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
Very nicely done. I've restored shrinkwrap to its previous state, but other than that no comments :)
Member
|
Merged manually. Thank you! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR solving issue #740
Added a new 1 column section if no section currently exists on selected page. Also added a minimal test for this use case.
P.S. I also updated what I think is a typo on line 183 in page-clientsidewebpart-add.spec.ts. Not 100% sure what the intention of the test case is, but the way I interpret it suggests it was a minor typo.