Skip to content

SPFx project upgrade 1.7.1 to 1.8.2 doesn't suggest react type resolution update #968

@YannickRe

Description

@YannickRe

Running the project upgrade command on a 1.7.1 project to get 1.8.2 doesn't suggest an update to the resolutions section of package.json.

Package.json contains:

  "resolutions": {
    "@types/react": "16.4.2"
  },

Command output:

o365$ spfx project upgrade
Execute in command line
-----------------------
npm i @microsoft/[email protected] @types/[email protected] @types/[email protected] @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] [email protected] [email protected] [email protected] -SE
npm i @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] -DE
npm dedupe

./.yo-rc.json
-------------
Update version in .yo-rc.json:
{
  "@microsoft/generator-sharepoint": {
    "version": "1.8.2"
  }
}


./tsconfig.json
---------------
Update tsconfig.json extends property:
{
  "extends": "./node_modules/@microsoft/rush-stack-compiler-2.9/includes/tsconfig-web.json"
}

Update tsconfig.json inlineSources value:
{
  "compilerOptions": {
    "inlineSources": false
  }
}

Update tsconfig.json strictNullChecks value:
{
  "compilerOptions": {
    "strictNullChecks": false
  }
}

Update tsconfig.json noUnusedLocals value:
{
  "compilerOptions": {
    "noUnusedLocals": false
  }
}

I expected a suggestion to update package.json to:

  "resolutions": {
    "@types/react": "16.7.22"
  }

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions