here it is actually wrong
|
workflow.name = workflow.name.replace('{{ name }}', options.name ?? solutionName); |
as the workflow name property is name: "Deploy Solution {{ name }}"
The idea was that when someone will not set name option then we give a default name for the workflow replacing the {{ name }} with spfx solution name. But when someone would use the name option we should replace the full name not just the {{ name }} tag.
here it is actually wrong
cli-microsoft365/src/m365/spfx/commands/project/project-github-workflow-add.ts
Line 142 in 4a1036f
as the workflow name property is
name: "Deploy Solution {{ name }}"The idea was that when someone will not set
nameoption then we give a default name for the workflow replacing the{{ name }}with spfx solution name. But when someone would use thenameoption we should replace the full name not just the{{ name }}tag.