Skip to content

Replace 'defines correct option sets' tests with validation tests #4068

@waldekmastykarz

Description

@waldekmastykarz

In some commands we have the 'defines correct option sets' test that verifies if the command defines the correct option sets. Thinking of it, it's not the right way about checking validation. Each time we change something about the command's option sets, we need to adjust the tests as well, which means we need to apply each change in two places. It also tightly couples the implementation with the test. A better way about it would be to add tests that verify that command fails validation when incorrect options are passed, irrespective how it's implemented in the command itself.

Before we start implementation, we should list all commands that require changing.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions