Skip to content

Enhancement: replace validation with optionsets #3218

@waldekmastykarz

Description

@waldekmastykarz

As we've extended CLI with support for optionsets (#2998), we can proceed and replace the validation of option sets in all commands with optionset definitions. We should also replace the obsolete validation tests with ones that check that correct optionsets have been defined in each command.

Following commands need updating:

  • aad app get
  • aad app remove
  • aad app role add
  • aad app role list
  • aad app role remove
  • aad app set
  • aad approleassignment add
  • aad approleassignment list
  • aad approleassignment remove
  • aad groupsettingtemplate get
  • aad o365group conversation post list
  • aad o365group teamify
  • aad o365group user add
  • aad o365group user remove
  • aad o365group user set
  • aad sp add
  • aad sp get
  • aad user get
  • aad user set
  • adaptivecard send // while the command expects either card or title it also allows both options so this validation can't be replaced by an option set which defines one of options but doesn't allow both
  • outlook message list
  • outlook message move
  • pa app get
  • planner bucket add
  • planner bucket list
  • planner plan add
  • [ ] planner plan get // not possible due to deprecated options, update in v6
  • planner plan list
  • planner task add
  • planner task list // options in the set are optional and can't be validated with an option set
  • planner task set // options in the set are optional and can't be validated with an option set
  • pp managementapp add
  • spo app deploy
  • spo app get
  • spo contenttype get
  • spo contenttype remove
  • spo field get
  • spo field remove
  • spo field set
  • spo file checkin
  • spo file checkout
  • spo file get
  • spo file remove
  • spo file sharinginfo get
  • spo group get
  • spo group remove
  • spo group user add
  • spo group user list
  • spo group user remove
  • spo list contenttype add
  • spo list contenttype default set
  • spo list contenttype list
  • spo list contenttype remove
  • spo list get
  • spo list label get
  • spo list label set
  • spo list remove
  • spo list sitescript get
  • spo list view field add
  • spo list view field remove
  • spo list view field set
  • spo list view get
  • spo list view list
  • spo list view remove
  • spo list view set
  • spo list webhook add
  • spo list webhook get
  • [ ] spo list webhook list // options in the set are optional and can't be validated with an option set
  • spo list webhook remove
  • spo list webhook set
  • spo listitem add
  • spo listitem attachment list
  • spo listitem get
  • spo listitem isrecord
  • [ ] spo listitem list // not possible due to deprecated options, update in v6
  • spo listitem record declare
  • spo listitem record undeclare
  • spo listitem remove
  • spo listitem set
  • spo site apppermission add
  • [ ] spo site apppermission list // options in the set are optional and can't be validated with a set
  • spo site apppermission remove
  • spo site apppermission set
  • spo term add
  • spo term get
  • spo term group get
  • spo term list
  • spo term set add
  • spo term set get
  • spo term set list
  • spo user get
  • spo user remove
  • teams app install
  • [ ] teams app list // options are optional so can't validate using an option set just yet
  • teams app update
  • teams channel add
  • teams channel get
  • teams channel list
  • teams channel member set
  • teams channel member list
  • teams channel remove
  • teams chat get
  • teams chat message send
  • teams channel member add
  • teams tab get
  • teams team get
  • teams user app list
  • todo list remove
  • todo list set
  • todo task add
  • todo task list
  • todo task remove
  • todo task set
  • yammer user get
  • fix tests and coverage

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions