Discussed in #2979
Originally posted by appieschot January 25, 2022
Discussion started here: #2918 (comment)
We currently have some base methods that provide helper functionality in that base class. We also use the getAppObjectId in the m365 aad app commands. We could pick to have a an abstracted AppCommand class so we can have 1 implementation instead of the multitude we have now (used in app-get, app-role-add, app-role-delete, app-role-list and app-set commands (as well as this one but this might be a bit of an odd duck as this in the future should inherit from whatever we decide in #2961.
Yet discussing that @waldekmastykarz pointed out it makes more sense to revisit and refactor or extend our Utils and provide (grouped) helper methods there. It feels like we should design both how our Utils should work and to research what we could move there for a V1.
Discussed in #2979
Originally posted by appieschot January 25, 2022
Discussion started here: #2918 (comment)
We currently have some base methods that provide helper functionality in that base class. We also use the
getAppObjectIdin them365 aad appcommands. We could pick to have a an abstractedAppCommandclass so we can have 1 implementation instead of the multitude we have now (used inapp-get,app-role-add,app-role-delete,app-role-listandapp-setcommands (as well as this one but this might be a bit of an odd duck as this in the future should inherit from whatever we decide in #2961.Yet discussing that @waldekmastykarz pointed out it makes more sense to revisit and refactor or extend our
Utilsand provide (grouped) helper methods there. It feels like we should design both how ourUtilsshould work and to research what we could move there for a V1.