Skip to content

Bug: superseding rules works incorrectly #2593

@waldekmastykarz

Description

@waldekmastykarz

Discussed in #2590

When upgrading SPFx project from 1.11 to 1.12, CLI won't suggest removing rush-stack-compiler 3.3. While the rule is there, it's superseded by installing rush-stack-compiler 3.7. The problem is, that currently superseding doesn't take into account the difference between installing and uninstalling the package. We need to think about how to handle it as currently superseding is handled centrally outside the rule.

One way could be to replace the array of superseded rule IDs with a method that takes a rule as an argument. That way, the rule could examine other rule's properties and return a bool true or false depending if the rule should be superseded or not.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bughelp wantedkeep-openMake sure this issue is never automatically marked as stale.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions