Skip to content

Bug report: incorrect order of scripts to execute when upgrading SPFx projects #2358

@waldekmastykarz

Description

@waldekmastykarz

Description

When upgrading SPFx project from v1.10.0 to latest preview, we show scripts to execute in wrong order, which leads to a broken project.

Steps to reproduce

m365 spfx project upgrade --preview -o md > report.md on an SPFx v1.10.0 react web part project.

Expected result

npm un -S @types/react @types/react-dom @types/webpack-env @types/es6-promise
npm un -D @types/chai @types/mocha
npm i -SE @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] [email protected] [email protected] [email protected]
npm i -DE @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] [email protected] @types/[email protected] @types/[email protected] @types/[email protected] @types/[email protected] @microsoft/[email protected]

Actual result

npm i -SE @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] [email protected] [email protected] [email protected]
npm i -DE @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] @microsoft/[email protected] [email protected] @types/[email protected] @types/[email protected] @types/[email protected] @types/[email protected] @microsoft/[email protected]
npm un -S @types/react @types/react-dom @types/webpack-env @types/es6-promise
npm un -D @types/chai @types/mocha

Notice how uninstall comes after install which means that whatever new versions have been installed, they're immediately uninstalled.

Environment

Latest CLI

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions