Description
When recently doing an SPFX update from 1.10 -> 1.11 the notification said:
Update tsconfig.json include property:
{
"include": [
"src/**/*.tsx"
]
}
Without thinking enough about the ramifications, it I changed my existing line from *.ts to *.tsx as instructed. What I have since realized is that I have updated my localization to use .ts files instead of .js files (because it's easier to see issues with string names and inclusion) and all the sudden all that code wasn't working. Since I had done a lot of other package updates it took me a while to track down but in retrospect what I should have done was either added *.tsx (given it's an array) or changed *.ts to *.ts*. However, since I don't exactly know why the change was being suggested in the first place, I'm not entirely sure that covers it so maybe the wording needs to be updated, or maybe just use the wildcard?
Steps to reproduce
N/A
Expected result
N/A
Actual result
N/A
Environment
Windows 10 - 3.1.0
Description
When recently doing an SPFX update from 1.10 -> 1.11 the notification said:
Without thinking enough about the ramifications, it I changed my existing line from *.ts to *.tsx as instructed. What I have since realized is that I have updated my localization to use .ts files instead of .js files (because it's easier to see issues with string names and inclusion) and all the sudden all that code wasn't working. Since I had done a lot of other package updates it took me a while to track down but in retrospect what I should have done was either added *.tsx (given it's an array) or changed *.ts to *.ts*. However, since I don't exactly know why the change was being suggested in the first place, I'm not entirely sure that covers it so maybe the wording needs to be updated, or maybe just use the wildcard?
Steps to reproduce
N/A
Expected result
N/A
Actual result
N/A
Environment
Windows 10 - 3.1.0