spo-listitem-get updated tests for access tokens and connections

Mark Powney · Mark Powney · commit f7e33da09ca2 · 2018-06-11T09:40:44.000+10:00
diff --git a/src/o365/spo/commands/listitem/listitem-get.spec.ts b/src/o365/spo/commands/listitem/listitem-get.spec.ts
@@ -14,7 +14,6 @@ describe(commands.LISTITEM_GET, () => {
   let vorpal: Vorpal;
   let log: any[];
   let cmdInstance: any;
-  let cmdInstanceLogSpy: sinon.SinonSpy;
   let trackEvent: any;
   let telemetry: any;
 
@@ -68,7 +67,6 @@ describe(commands.LISTITEM_GET, () => {
         log.push(msg);
       }
     };
-    cmdInstanceLogSpy = sinon.spy(cmdInstance, 'log');
     auth.site = new Site();
     telemetry = null;
   });
@@ -126,9 +124,9 @@ describe(commands.LISTITEM_GET, () => {
     auth.site = new Site();
     auth.site.connected = false;
     cmdInstance.action = command.action();
-    cmdInstance.action({ options: { debug: false, webUrl: 'https://contoso.sharepoint.com', listTitle: 'Demo List', id: expectedId } }, () => {
+    cmdInstance.action({ options: { debug: false, webUrl: 'https://contoso.sharepoint.com', listTitle: 'Demo List', id: expectedId } }, (err?: any) => {
       try {
-        assert(cmdInstanceLogSpy.calledWith(new CommandError('Connect to a SharePoint Online site first')));
+        assert.equal(JSON.stringify(err), JSON.stringify(new CommandError('Connect to a SharePoint Online site first')));
         done();
       }
       catch (e) {
@@ -395,13 +393,14 @@ describe(commands.LISTITEM_GET, () => {
     cmdInstance.action = command.action();
     cmdInstance.action({
       options: {
+        id: 1,
         listId: "BC448D63-484F-49C5-AB8C-96B14AA68D50",
         webUrl: "https://contoso.sharepoint.com",
         debug: false
       }
-    }, () => {
+    }, (err?: any) => {
       try {
-        assert(cmdInstanceLogSpy.calledWith(new CommandError('Error getting access token')));
+        assert.equal(JSON.stringify(err), JSON.stringify(new CommandError('Error getting access token')));
         done();
       }
       catch (e) {
