Skip to content

Commit 46342de

Browse files
robgilbreathclaude
andauthored
Move validate/publish to ubuntu-latest; release 2.0.53 (#13)
* Move validate/publish to ubuntu-latest; setup Node before toolchain check The org runner group rejects jobs from public repos, so `runs-on: self-hosted` has left every run since 2026-06-19 unschedulable. Switch both workflows to GitHub-hosted runners and install the .nvmrc Node ahead of verify-node-toolchain so it checks our toolchain, not the image's system Node. Refs pncit/.github#3 Co-Authored-By: Claude Code <[email protected]> * Release 2.0.53 CI-only release: every PR into master must bump the version (validate.yml gate), and this one moves the workflows to GitHub-hosted runners. Refs pncit/.github#3 Co-Authored-By: Claude Code <[email protected]> * Pin [email protected] in publish Was floating on @latest. Org standard is npm 12 (matches shared-actions validate-codebase, which pins 12.0.2); npm/cli#9722 was fixed in 12.0.1. Co-Authored-By: Claude Code <[email protected]> --------- Co-authored-by: Claude Code <[email protected]>
1 parent 16afd21 commit 46342de

4 files changed

Lines changed: 28 additions & 11 deletions

File tree

‎.github/workflows/npm-publish.yml‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,11 @@ jobs:
3434
(github.event.workflow_run.conclusion == 'success'
3535
&& github.event.workflow_run.head_branch == 'master'
3636
&& github.event.workflow_run.event == 'push')
37-
runs-on: self-hosted
37+
# GitHub-hosted: the org's self-hosted runner group does not accept jobs
38+
# from public repos, so `self-hosted` could never be scheduled here.
39+
# Auth is OIDC trusted publishing (id-token above), which works from
40+
# GitHub-hosted runners without any runner-local credentials.
41+
runs-on: ubuntu-latest
3842
steps:
3943
- uses: actions/checkout@v6
4044
with:
@@ -54,8 +58,9 @@ jobs:
5458
cache-dependency-path: |
5559
package-lock.json
5660
61+
# Pinned: org standard is npm 12 (matches shared-actions validate-codebase). Bump deliberately.
5762
- name: Update npm
58-
run: npm install -g npm@latest
63+
run: npm install -g npm@12.0.2
5964

6065
- name: Install dependencies
6166
run: npm ci

‎.github/workflows/validate.yml‎

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,9 @@ jobs:
1818
# Push events (merge to master) always validate — that run is what gates
1919
# publishing. PR events only run when the PR's head branch lives in THIS
2020
# repo (which requires write access); PRs from forks have a different head
21-
# repo and skip the job, so untrusted fork code never reaches the
22-
# self-hosted runner.
21+
# repo and skip the job. On the ephemeral GitHub-hosted runner below this
22+
# is a POLICY choice, not a runner-safety requirement (fork runs are
23+
# sandboxed and get no secrets) — drop the `if` to give fork PRs CI.
2324
#
2425
# We gate on head-repo identity rather than author_association because the
2526
# latter downgrades private org members to "CONTRIBUTOR" in the event
@@ -34,7 +35,11 @@ jobs:
3435
if: >-
3536
github.event_name != 'pull_request' ||
3637
github.event.pull_request.head.repo.full_name == github.repository
37-
runs-on: self-hosted
38+
# GitHub-hosted: the org's self-hosted runner group does not accept jobs
39+
# from public repos (allows_public_repositories=false, on purpose — it
40+
# keeps fork PRs off the fleet), so `self-hosted` here could never be
41+
# scheduled. Nothing below depends on runner-local state.
42+
runs-on: ubuntu-latest
3843
steps:
3944
# Up-front checkout: required so the local composite actions
4045
# (./.github/actions/*) exist on the runner before they're referenced,
@@ -45,9 +50,16 @@ jobs:
4550
with:
4651
fetch-depth: 2
4752

48-
# Env check: fail fast if the runner's Node/npm majors don't match what
49-
# the repo expects (NODE_MAJOR_VERSION / NPM_MAJOR_VERSION are pncit
50-
# org-level Actions variables).
53+
# Install the repo's Node (.nvmrc) before the toolchain check: the hosted
54+
# image's system Node is whatever Ubuntu ships, not necessarily ours.
55+
# validate-codebase below runs setup-node again; that's a cache hit.
56+
- uses: actions/setup-node@v6
57+
with:
58+
node-version-file: .nvmrc
59+
60+
# Env check: fail fast if the Node/npm majors don't match what the repo
61+
# expects (NODE_MAJOR_VERSION / NPM_MAJOR_VERSION are pncit org-level
62+
# Actions variables). Also catches .nvmrc drifting from the org standard.
5163
- uses: ./.github/actions/verify-node-toolchain
5264
with:
5365
node-major-version: ${{ vars.NODE_MAJOR_VERSION }}

‎package-lock.json‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@pncit/node-quickbooks",
3-
"version": "2.0.52",
3+
"version": "2.0.53",
44
"description": "node.js client for Intuit's IPP QuickBooks V3 API.",
55
"main": "index.js",
66
"types": "index.d.ts",

0 commit comments

Comments
 (0)