Repository navigation
Fix multi-period annualization inference - #304
Merged
timkpaine merged 3 commits intoAug 11, 2026
Merged
Conversation
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
30minperiod inference regression assertionFor 30-minute data,
infer_nperiodspreviously returned 10,886,400 periods per year instead of 12,096. That inflated annualized Sharpe and Sortino ratios by 30x.Fixes #303.
Validation
python -m pytest -q -ra— 52 passedruff check ffn/core.py— passedgit diff --check— passedAI assistance was used to identify the arithmetic inconsistency, draft the regression coverage, and run validation. The reproduction, one-line production fix, test expectations, and final diff were reviewed before publication.