Repository navigation
Merged
Conversation
…nual | Added unit test | #685
Member
|
I'm confused, why was the other PR closed and a new one created?
That's strange. I'll take a look. |
Member
Fixed via 629fb8d |
vanruesc
approved these changes
Feb 27, 2025
Member
|
Thanks for this, I'll take care of the remaining clean up work. Also, if you close a PR by accident, it's better to reopen it instead of creating a new one. |
Contributor
Author
Great! Thank you very much, sorry if I caused some inconvenience |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #685
Description
Errors / Problems