Repository navigation
feat/Add ScanlineEffect & demo to v7 - #602
Merged
Merged
Conversation
balraj-johal
commented
Feb 20, 2024
balraj-johal
commented
Feb 20, 2024
balraj-johal
commented
Feb 20, 2024
balraj-johal
left a comment
balraj-johal
left a comment
Author
There was a problem hiding this comment.
Have commented a few questions I had :)
balraj-johal
marked this pull request as ready for review
February 20, 2024 19:53
3 tasks done
vanruesc
requested changes
Feb 20, 2024
Co-authored-by: Raoul v. R. <[email protected]>
Author
|
@vanruesc thanks for the review! I think I've addressed all your comments :) |
vanruesc
reviewed
Feb 20, 2024
vanruesc
approved these changes
Feb 20, 2024
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #595
Description
This PR ports the v6 implementation of the ScanlineEffect to the v7 alpha build. Changes made were primarily modelled after the v7 version of the VignetteEffect.