Implement ASCIIEffect #685

Activity

1. vanruesc

   added

   feature

   on Feb 17, 2025
2. vanruesc

   added this to the v7 milestone on Feb 17, 2025
3. vanruesc

   removed

   feature

   on Feb 17, 2025
4. LucaArgentieri commented on Feb 17, 2025

   

   LucaArgentieri

   on Feb 17, 2025

   Last edited by LucaArgentieri

   Contributor

   More actions

   I’m working on it!

   Do I have to wait for the effect in the package to be published before creating the demo/unit test?
5. vanruesc commented on Feb 17, 2025

   

   vanruesc

   on Feb 17, 2025

   MemberAuthor

   More actions

   Do I have to wait

   No, you can go ahead 👌

   FYI: there are some relevant notes in #600 for the PR workflow.
6. vanruesc

   assigned

   LucaArgentieri

   on Feb 17, 2025
7. LucaArgentieri commented on Feb 18, 2025

   

   LucaArgentieri

   on Feb 18, 2025

   Contributor

   More actions

   @vanruesc How can I test the effect if I cannot import it in the demo?
   Forgive me if I ask for banalities 🙇‍♂️
8. vanruesc commented on Feb 18, 2025

   

   vanruesc

   on Feb 18, 2025

   Last edited by vanruesc

   MemberAuthor

   More actions

   I'm not sure I understand the question 🤔

   My approach would be like this:

   1. Check out the v7 branch.
   2. Create ASCIITexture in src/textures and ASCIIEffect in src/effects (using the v6 implementation as reference).
   3. Update the index.js files in those folders to re-export the new classes.
   4. Create ascii.js in manual/assets/js/src/demos/ (copying an existing demo such as color-depth).
   5. Create a new manual demo page ascii.en.md in manual/content/demos/special-effects/.
   6. Use npm run watch to build and run the manual locally.
   7. ???
   8. profit

   It's also a good idea to run npm test before creating a PR to auto-fix formatting issues.

   If anything is unclear feel free to ask 👍

   👍React with 👍1Reacted by Luca Argentieri
9. LucaArgentieri commented on Feb 19, 2025

   

   LucaArgentieri

   on Feb 19, 2025

   Contributor

   More actions

   Hi @vanruesc,
   I got this error:

   • Could not find a valid mainImage or mainUv function (ASCIIEffect) , something seems to be broken in the ascii.frag

   This test fail:

   • ✘ [fail]: effects › ASCIIEffect › can be created and destroyed Error thrown in test
     
     ReferenceError {
       message: 'document is not defined',
     }
     
     

   I also commented setSize because I can’t access this.resolution and don’t know if this function is useful.

   Is it better for you to review the PR so that you understand the errors?

   I hope I didn’t create problems and complicated the task
10. vanruesc

    added 2 commits that reference this issue on Feb 27, 2025

    Add ASCIITexture and ASCIIEffect (#688)

    ...

    1208493

    Refactor ASCIITexture and ASCIIEffect

    ...

    ae51dbc
11. vanruesc

    closed this as completedon Mar 2, 2025
12. vanruesc commented on Mar 2, 2025

    

    vanruesc

    on Mar 2, 2025

    MemberAuthor

    More actions

    FYI: I've updated the demos to make them look a bit more interesting.

    You can get some pretty cool visuals when blending the ASCII effect with the original image:

    

    🚀React with 🚀1Reacted by Luca Argentieri