Skip to content

Implement color grading effects #584

Closed
Closed

Description

@vanruesc

Description

Implement a CDLEffect BrightnessContrastEffect, HueSaturationEffect and SepiaEffect.

Reference:

Tasks

  • Create CDLEffect.
  • Create cdl demo.
  • Add unit test.

Implementation Details

  • Use brightness-contrast, hue-saturation and sepia manual demos from v6 as reference.

Activity

  1. added this to the v7 milestone on Feb 16, 2024
  2. donmccurdy commented on Feb 17, 2024

    @donmccurdy
    Member

    I might suggest going an additional step and include a CDLEffect, based on ASC CDL v1.2 color grading. It's a single effect with four parameters (vec3 slope, vec3 offset, vec3 power, float saturation) that should be able to accomplish everything supported by the other effects listed here. I'm making a similar proposal for three.js core fairly soon.

  3. vanruesc commented on Feb 17, 2024

    @vanruesc
    MemberAuthor

    That's even better 👍 I'll update the task.

  4. vanruesc commented on Mar 14, 2024

    @vanruesc
    MemberAuthor

    FYI: this ticket is not a blocker for v7 and since I'm not familiar with CDL, I'll leave you to it @donmccurdy. Meaning I won't be checking in here 😄

  5. donmccurdy commented on Mar 14, 2024

    @donmccurdy
    Member

    Thanks @vanruesc! Next on my list after a glTF Transform v4 release that has been taking me longer than planned. 😅

  6. added a commit that references this issue on Aug 17, 2025
    43c0b3a
  7. vanruesc commented on Aug 29, 2025

    @vanruesc
    MemberAuthor

    Closing as completed via #723.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions