Reconsider usage of accessor properties #349

Activity

1. vanruesc

   added

   enhancementEnhancement of existing functionalityEnhancement of existing functionality

   on Feb 23, 2022
2. drcmda commented on Feb 23, 2022

   

   drcmda

   on Feb 23, 2022

   Last edited by drcmda

   Member

   More actions

   I'll copy the middle in here for reference:

   we won't be able to set and, more importantly, spread props over passes, we'll have to know all props beforehand and translate them to functions. functions cannot be expressed declaratively, they are not serializable either.

   good examples could be threejs, or the dom, they strike a sensible balance between atomics and more complex functions that will either carry out calculations or set multiple props at once. the upside for atomics is that they can easily by driven by state models and spread over the surface.

   another upside is maintenance for abstractions of pp. if pp updates and introduces a new atomic, say foo, the userland solution or library using it just needs to npm update and foo will work without having to adjust the abstraction.

   we are also publishing types for raw postprocessing, https://github.com/pmndrs/react-postprocessing/blob/master/types/postprocessing.d.ts that would be another "abstraction" that's currently quite simple to adjust.
3. vanruesc commented on Feb 23, 2022

   

   vanruesc

   on Feb 23, 2022

   MemberAuthor

   More actions

   good examples could be threejs, or the dom, they strike a sensible balance between atomics and more complex functions that will either carry out calculations or set multiple props at once.

   That sounds reasonable. One motivation behind the move towards methods was that a lot of settings on effects need to trigger shader recompilations to take effect. Using method calls makes it clear that changes will be expensive as opposed to just changing the value of a seemingly harmless property.
4. vanruesc

   added 2 commits that reference this issue on Mar 7, 2022

   Replace methods with accessors

   ...

   de14746

   Replace methods with accessors

   ...

   d5c91e2
5. vanruesc commented on Mar 9, 2022

   

   vanruesc

   on Mar 9, 2022

   MemberAuthor

   More actions

   Getter and setter methods have been converted into accessor properties in [email protected]. I had my concerns regarding accessors, but it's ultimately ease-of-use and consistency that matters.

   👍React with 👍1Reacted by Tyler Sammy
6. vanruesc

   closed this as completedon Mar 9, 2022