NormalPass, SSAOPass: Enable passes to work with flat shading, back side material settings  #292

Activity

1. gkjohnson

   added

   feature requestNew feature requestNew feature request

   on May 9, 2021
2. vanruesc commented on May 9, 2021

   

   vanruesc

   on May 9, 2021

   Member

   More actions

   Thanks for the report!

   The NormalPass does make use of the OverrideMaterialManager and the side property should already be handled (see #265). The flatShading property is not supported yet. Handling this property will increase the amount of override materials from 9 to 18. This is, of course, awful, but I think this should be the last property that needs to be accounted for. The override material system is also about to become obsolete relatively soonish, now that the MRT PR has been merged.

   I'll publish a fix for flatShading soon.

   🎉React with 🎉3Reacted by Garrett Johnson, Gianmarco and Jonathan Chemla
3. vanruesc commented on May 9, 2021

   

   vanruesc

   on May 9, 2021

   Member

   More actions

   Modified fiddle with override material workaround enabled: https://jsfiddle.net/8georca4/

   🎉React with 🎉1Reacted by Garrett Johnson
4. gkjohnson commented on May 9, 2021

   

   gkjohnson

   on May 9, 2021

   Author

   More actions

   OverrideMaterialManager.workaroundEnabled = true;

   Oops I missed that this needed to be explicitly enabled. Thanks!

   The override material system is also about to become obsolete relatively soonish, now that the MRT PR has been merged.

   I'm pretty excited for the improvements that MRT will bring but how do you anticipate it removing the need for an override workaround system? Three.js' scene.overrideMaterial will still have the same limitations so I would think you'd still have to use a similar kind of workaround. But now you'd be able to use an override material that draws to multiple buffers at once, instead. Maybe I've misunderstood, though!
5. vanruesc commented on May 9, 2021

   

   vanruesc

   on May 9, 2021

   Member

   More actions

   how do you anticipate it removing the need for an override workaround system?

   The workaround attempts to fix the shortcomings of the override material system, so it's only necessary because we use override materials. With MRT we should be able to render geometry data (normals, positions, roughness, etc.) into additional buffers during the initial RenderPass without having to re-render the scene with override materials. Since there are no other use cases for scene.overrideMaterial in this library, the NormalPass, DepthPass, LuminancePass and OverrideMaterialManager will eventually become obsolete.

   Three's current built-in materials are quite rigid and hard to extend. I think we still have to wait for NodeMaterials and declarative shader manipulation features to actually make effective use of MRT in the RenderPass.

   👍React with 👍2Reacted by William McMurray and Jonathan Chemla
6. vanruesc

   added a commit that references this issue on May 9, 2021

   Add support for flatShading

   ...

   This issue will close once commit edb04e1 is merged into the 'main' branch.

   edb04e1
7. vanruesc

   closed this as completedin edb04e1on May 9, 2021
8. vanruesc commented on May 9, 2021

   

   vanruesc

   on May 9, 2021

   Member

   More actions

   Fixed in [email protected].
9. gkjohnson commented on May 10, 2021

   

   gkjohnson

   on May 10, 2021

   Author

   More actions

   Three's current built-in materials are quite rigid and hard to extend. I think we still have to wait for NodeMaterials and declarative shader manipulation features to actually make effective use of MRT in the RenderPass.

   Yes I'm excited to see what Node materials bring. I think they'll be pretty enabling in a lot of ways.

   Thanks for the quick fix!

   👍React with 👍2Reacted by William McMurray and Jonathan Chemla