Skip to content

OutlineEffect only show one side on a Double Side ShapeGeometry #265

Closed

Description

@lknstanley

Description of the bug

OutlineEffect only apply one side to ShapeGeometry mesh even the material set the side to DoubleSide.

To Reproduce

  1. Create Shape and ShapeGeometry
  2. Modify the material to use DoubleSide for side
  3. Add shape mesh to scene
  4. Initialise EffectComposer and OutlineEffect
  5. Add shape mesh to OutlineEffect selection

Link to demo

Expected behavior

I can see the outline on both side.

Screenshots

Frontside
front

Backside
back

Library versions used

  • Three: 0.124.x
  • Post Processing: 6.x.x

Desktop

  • OS: Windows 10
  • Browser Chrome Version 87.0.4280.141
  • Graphics hardware: NVIDIA RTX 2060 SUPER

Activity

  1. vanruesc commented on Jan 29, 2021

    @vanruesc
    Member

    Thanks for reporting this.

    The OutlinePass renders the depth of selected objects via three's override material system. Unfortunately, this system completely ignores all values of the original materials. This library provides an overide material workaround that fixes important issues with skinned and instanced meshes, but it doesn't add support for all individual material settings like normalMap and side because this would drastically increase the number of additional override materials.

    However, I think that the side field doesn't really belong to the material because it affects how the geometry is rendered so I think it should be fine to support it. I'll publish a patch in a bit.

    In any case, please make sure the override material workaround is enabled.

  2. vanruesc commented on Jan 30, 2021

    @vanruesc
    Member

    Added support for BackSide and DoubleSide to OverideMaterialManager in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementEnhancement of existing functionality

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions