Repository navigation
Unregister the system / unload effects #216
Description
Hello,
I'm stuck on some silly detail. I have a postprocessing system registered this way.
load().then((assets) => { AFRAME.registerSystem("postprocessing", postprocessingSystem.setAssets(assets)); }).catch(console.error);
The script is called by a component in an A-frame .
I need to remove the component under certain actions and its effects at the same time.
-First problem: postprocessing remains active.
-second problem: if I reactivate it for the second time I logically get:
Error: The system postprocessing has been already registered. Check that you are not loading two versions of the same system or two different systems of the same name. at Object.module.exports.registerSystem (system.js:143) at (index):668
Question: what is the method to return to withdraw the system or the effects?
Thank you in advance,
Ludovic
Activity
[-]Unregister the system[/-][+]Unregister the system / unload effects[/+]vanruesc commentedon Aug 2, 2020
Hi,
the a-frame example is pretty much just a hacky proof of concept that doesn't really harmonize with
a-frame. I don't think it's possible to unregister systems in a-frame anymore, but you could add custom enable/disable logic: https://jsfiddle.net/537osy0q/.A proper solution would probably consist of a more integrated post processing System with pass and effect Components.
illiu-maker commentedon Aug 3, 2020
I will try this way :) thanks you
arpu commentedon Feb 19, 2021
@vanruesc this does not work in webxr? do you have any idea what the problem is?
vanruesc commentedon Feb 19, 2021
@arpu I currently have no plans to work on XR related stuff because I want to focus on other issues and features first.
There should be some open issues regarding post processing in XR over at three.js which probably apply to this library as well. I think the main issue is that three uses some special internal cameras for VR.
arpu commentedon Feb 19, 2021
yeaah i looked at https://github.com/mrdoob/three.js/blob/dev/examples/jsm/objects/Reflector.js#L105
this works fine in webxr
example for webxr is https://threejs.org/examples/?q=sandbox#webxr_vr_sandbox