Skip to content

Commit d714a20

Browse files
committed
Use explicit default value
and use more accurate param type
1 parent cc878b4 commit d714a20

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎src/core/EffectComposer.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,14 @@ export class EffectComposer {
3939
* @param {Boolean} [options.depthBuffer=true] - Whether the main render targets should have a depth buffer.
4040
* @param {Boolean} [options.stencilBuffer=false] - Whether the main render targets should have a stencil buffer.
4141
* @param {Number} [options.multisampling=0] - The number of samples used for multisample antialiasing. Requires WebGL 2.
42-
* @param {Number} [options.frameBufferType] - The type of the internal frame buffers. It's recommended to use HalfFloatType if possible.
42+
* @param {Number} [options.frameBufferType=UnsignedByteType] - The type of the internal frame buffers. It's recommended to use HalfFloatType if possible.
4343
*/
4444

4545
constructor(renderer = null, {
4646
depthBuffer = true,
4747
stencilBuffer = false,
4848
multisampling = 0,
49-
frameBufferType
49+
frameBufferType = UnsignedByteType
5050
} = {}) {
5151

5252
/**

‎types/index.d.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4792,7 +4792,7 @@ export class EffectComposer implements Resizable, Disposable {
47924792
* @param {Boolean} [options.stencilBuffer=false] - Whether the main render targets should have a stencil buffer.
47934793
* @param {Boolean} [options.alpha] - Deprecated. Buffers are always RGBA since three r137.
47944794
* @param {Number} [options.multisampling=0] - The number of samples used for multisample antialiasing. Requires WebGL 2.
4795-
* @param {Number} [options.frameBufferType] - The type of the internal frame buffers. It's recommended to use HalfFloatType if possible.
4795+
* @param {TextureDataType} [options.frameBufferType=UnsignedByteType] - The type of the internal frame buffers. It's recommended to use HalfFloatType if possible.
47964796
*/
47974797
constructor(
47984798
renderer?: WebGLRenderer,
@@ -4806,7 +4806,7 @@ export class EffectComposer implements Resizable, Disposable {
48064806
stencilBuffer?: boolean;
48074807
alpha?: boolean;
48084808
multisampling?: number;
4809-
frameBufferType?: number;
4809+
frameBufferType?: TextureDataType;
48104810
}
48114811
);
48124812

0 commit comments

Comments
 (0)