Skip to content

Commit 03cbe76

Browse files
committed
Add multisampling fallback
Closes #749
1 parent 078a6d1 commit 03cbe76

2 files changed

Lines changed: 68 additions & 3 deletions

File tree

‎src/core/EffectComposer.js‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import { ClearMaskPass } from "../passes/ClearMaskPass.js";
1414
import { CopyPass } from "../passes/CopyPass.js";
1515
import { MaskPass } from "../passes/MaskPass.js";
1616
import { Pass } from "../passes/Pass.js";
17+
import { getSafeSamples } from "../utils/Compatibility.js";
1718
import { Timer } from "./Timer.js"; // TODO Replace with Timer from three, requires r179.
1819

1920
/**
@@ -163,14 +164,16 @@ export class EffectComposer {
163164

164165
set multisampling(value) {
165166

166-
if(this.multisampling === value) {
167+
const samples = (this.renderer === null) ? value : getSafeSamples(this.renderer, value);
168+
169+
if(this.multisampling === samples) {
167170

168171
return;
169172

170173
}
171174

172-
this.inputBuffer.samples = value;
173-
this.outputBuffer.samples = value;
175+
this.inputBuffer.samples = samples;
176+
this.outputBuffer.samples = samples;
174177
this.inputBuffer.dispose();
175178
this.outputBuffer.dispose();
176179

@@ -226,6 +229,10 @@ export class EffectComposer {
226229

227230
}
228231

232+
// Recheck multisampling fallback.
233+
const samples = this.multisampling;
234+
this.multisampling = samples;
235+
229236
renderer.autoClear = false;
230237
this.setSize(size.width, size.height);
231238

‎src/utils/Compatibility.js‎

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
// #region WebGL
2+
3+
/**
4+
* Returns a safe render target sample count for the given rendering context.
5+
*
6+
* Some environments, such as expo-gl, expose `renderbufferStorageMultisample` but throw when it is called.
7+
* This check detects that case and falls back to zero samples. Samples are also clamped by `gl.MAX_SAMPLES`.
8+
*
9+
* @internal
10+
* @see https://docs.expo.dev/versions/v57.0.0/sdk/gl-view/#webgl-api
11+
* @param renderer - A renderer.
12+
* @param samples - The desired sample count.
13+
* @return The safe sample count that is closest to the requested one.
14+
*/
15+
16+
export function getSafeSamples(renderer, samples) {
17+
18+
const gl = renderer.getContext();
19+
20+
if(samples <= 0 || typeof gl.renderbufferStorageMultisample !== "function") {
21+
22+
return 0;
23+
24+
}
25+
26+
const maxSamples = gl.getParameter(gl.MAX_SAMPLES);
27+
const safeSamples = Math.min(samples, maxSamples);
28+
29+
if(safeSamples <= 0) {
30+
31+
return 0;
32+
33+
}
34+
35+
const previousRenderbuffer = gl.getParameter(gl.RENDERBUFFER_BINDING);
36+
const renderbuffer = gl.createRenderbuffer();
37+
38+
try {
39+
40+
gl.bindRenderbuffer(gl.RENDERBUFFER, renderbuffer);
41+
gl.renderbufferStorageMultisample(gl.RENDERBUFFER, safeSamples, gl.RGBA8, 1, 1);
42+
43+
return safeSamples;
44+
45+
} catch(e) {
46+
47+
return 0;
48+
49+
} finally {
50+
51+
gl.bindRenderbuffer(gl.RENDERBUFFER, previousRenderbuffer);
52+
gl.deleteRenderbuffer(renderbuffer);
53+
54+
}
55+
56+
}
57+
58+
// #endregion

0 commit comments

Comments
 (0)