Repository navigation
[java] Fix #7275: Handle bare blocks in AvoidBranchingStatementAsLastInLoop - #7283
Merged
Merged
Conversation
Tests are good, but sometimes, too much of a good thing can be bad.
Contributor
|
Compared to main: (comment created at 2026-11-10 07:56:39+00:00 for 8b06c33) |
Member
|
Could you please check the "Maintainers are allowed to edit this pull request. " box, so that I can push the merge and the updated release notes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Walk through consecutive bare blocks when checking the enclosing loop in
AvoidBranchingStatementAsLastInLoop, preserving the existing finally handling and loop-type properties.Add five regression cases covering nested returns, loop/branch kinds, boundaries, disabled properties, and finally blocks.
Related issues
Validation
git diff --checkand XML parsing pass.--release 8. Native tests and the complete build remain for CI.Ready?
./mvnw clean verifypasses (checked automatically by github actions)